Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes v0.27.0 comments in datastore request #1080

Closed
wants to merge 3 commits into from
Closed

Fixes v0.27.0 comments in datastore request #1080

wants to merge 3 commits into from

Conversation

hrovira
Copy link
Contributor

@hrovira hrovira commented Jan 20, 2016

should resolve PR issue before. fixing comments in request.js

@hrovira
added info as per CONTRIBUTORS.md
39b4c89
@hrovira
fixing duplicated parameter description
13a268e 
there were duplicated parameter definitions for 'err', 'callback.entities', 'callback.nextQuery', 'callback.apiResponse'.

fixed by removing redundant.

fixes googleapis#1074
@hrovira
fixing comments
35f5cf7
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2016
@stephenplusplus
Copy link
Contributor

Thanks for going through all of this! In the future, you don't have to close a PR to completely change it. You can just force update your branch, and the PR will update. Are you up for trying to squash your commits into a single commit, or would you like me to handle that? (Here's a guide on that)

@hrovira
Copy link
Contributor Author

hrovira commented Jan 20, 2016

You can handle it if you wish, I tried reverting the change but github was
not cooperating, I ended up having to re-fork.

On Wed, Jan 20, 2016, 12:05 Stephen Sawchuk [email protected]
wrote:

Thanks for going through all of this! In the future, you don't have to
close a PR to completely change it. You can just force update your branch,
and the PR will update. Are you up for trying to squash your commits into a
single commit, or would you like me to handle that? (Here's a guide on
that
http://code.tutsplus.com/tutorials/rewriting-history-with-git-rebase--cms-23191
)

—
Reply to this email directly or view it on GitHub
#1080 (comment)
.

@stephenplusplus
Copy link
Contributor

Fixed by 073dd09. Thanks!

@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label Jan 21, 2016
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@renovate-bot
chore(deps): update dependency @types/uuid to v9 (#1080)
256c459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrovira @stephenplusplus @googlebot